From: František Dvořák <valtri@civ.zcu.cz>
Date: Sat, 9 Feb 2013 22:01:31 +0000 (+0100)
Subject: QA corner: memleak in daemon listen address code.
X-Git-Url: http://scientific.zcu.cz/git/?a=commitdiff_plain;h=f33dcec7088efa1315fa12f93f957f2a69af5ad4;p=jra1mw.git

QA corner: memleak in daemon listen address code.
---

diff --git a/org.glite.lb.client/src/notification.c b/org.glite.lb.client/src/notification.c
index b20663d..b811f0d 100644
--- a/org.glite.lb.client/src/notification.c
+++ b/org.glite.lb.client/src/notification.c
@@ -109,7 +109,6 @@ static int daemon_listen(edg_wll_Context ctx, const char *name, char *port, int
 	gaie = getaddrinfo (name, port, &hints, &ai);
 	if (gaie != 0 || ai == NULL) {
 		hints.ai_family = 0;
-		gaie = getaddrinfo (NULL, port, &hints, &ai);
 	}
 
 	gaie = getaddrinfo (name, port, &hints, &ai);
diff --git a/org.glite.lb.harvester/src/harvester.c b/org.glite.lb.harvester/src/harvester.c
index 1ea3ea2..afbffee 100644
--- a/org.glite.lb.harvester/src/harvester.c
+++ b/org.glite.lb.harvester/src/harvester.c
@@ -1648,7 +1648,6 @@ static int daemon_listen(thread_t *t, const char *name, char *port, int *conn_ou
 	gaie = getaddrinfo (name, port, &hints, &ai);
 	if (gaie != 0 || ai == NULL) {
 		hints.ai_family = 0;
-		gaie = getaddrinfo (NULL, port, &hints, &ai);
 	}
 
 	gaie = getaddrinfo (name, port, &hints, &ai);
diff --git a/org.glite.lb.logger/src/logd_proto.c b/org.glite.lb.logger/src/logd_proto.c
index f8b80b7..00ee06b 100644
--- a/org.glite.lb.logger/src/logd_proto.c
+++ b/org.glite.lb.logger/src/logd_proto.c
@@ -148,7 +148,6 @@ static int daemon_listen(const char *name, char *port, int *conn_out) {
 	gaie = getaddrinfo (name, port, &hints, &ai);
 	if (gaie != 0 || ai == NULL) {
 		hints.ai_family = 0;
-		gaie = getaddrinfo (NULL, port, &hints, &ai);
 	}
 
 	gaie = getaddrinfo (name, port, &hints, &ai);
diff --git a/org.glite.lbjp-common.server-bones/src/srvbones.c b/org.glite.lbjp-common.server-bones/src/srvbones.c
index 7b4814a..bf7f199 100644
--- a/org.glite.lbjp-common.server-bones/src/srvbones.c
+++ b/org.glite.lbjp-common.server-bones/src/srvbones.c
@@ -341,7 +341,6 @@ int glite_srvbones_daemon_listen(const char *name, char *port, int *conn_out) {
 	gaie = getaddrinfo (name, port, &hints, &ai);
 	if (gaie != 0 || ai == NULL) {
 		hints.ai_family = 0;
-		gaie = getaddrinfo (NULL, port, &hints, &ai);
 	}
 
 	gaie = getaddrinfo (name, port, &hints, &ai);