From: Daniel Kouřil <kouril@ics.muni.cz>
Date: Tue, 13 Dec 2011 09:30:22 +0000 (+0000)
Subject: some comments to address
X-Git-Tag: merge_30_head_take2_after~7
X-Git-Url: http://scientific.zcu.cz/git/?a=commitdiff_plain;h=ba530507db7c9e5e3cf1e5b2b1a2622ac111d2db;p=jra1mw.git

some comments to address
---

diff --git a/emi.canl.canl-c/src/canl.c b/emi.canl.canl-c/src/canl.c
index 0d13e6a..3bcdeae 100644
--- a/emi.canl.canl-c/src/canl.c
+++ b/emi.canl.canl-c/src/canl.c
@@ -120,7 +120,7 @@ int canl_io_connect(canl_ctx cc, canl_io_handler io, char * host, int port,
                 err = EHOSTUNREACH; //TODO check
                 set_error(glb_cc, err, posix_error, "Cannot resolve"
                         " the server hostname (%s)", host);
-                goto end;
+                goto end; /* XXX continue */
         }
 
         if (err)
@@ -169,6 +169,7 @@ static int try_connect(io_handler *io_cc, glb_ctx *glb_cc, char *addr,
         int addrtype, int port, struct timeval *timeout)
  * return 0 when successful
  * errno otherwise*/
+/* XXX use set_error on errors and return a CANL return code */
 static int try_connect(glb_ctx *glb_cc, io_handler *io_cc, char *addr,
         int addrtype, int port, struct timeval *timeout)
 {